Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chromium instead of a manual chrome download #178

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Use chromium instead of a manual chrome download #178

Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
63f1607
Update chrome.json
pat-s Sep 13, 2024
758511e
use array
pat-s Sep 13, 2024
9e06252
use `chromium-browser` on focal and jammy
pat-s Sep 13, 2024
a580eaf
fix redhat and centos
pat-s Sep 13, 2024
6c23c4e
schema
pat-s Sep 13, 2024
2d9355d
schema
pat-s Sep 13, 2024
966a768
use version
pat-s Sep 13, 2024
d109db3
epel-release for redhat and rocky
pat-s Sep 13, 2024
1a958e4
Update chrome.json
pat-s Sep 13, 2024
5471a7f
update pre-install
pat-s Sep 13, 2024
c171f1e
schema
pat-s Sep 13, 2024
9b665da
Update chrome.json
pat-s Sep 13, 2024
c682ca9
add 24.04
pat-s Sep 13, 2024
a77216a
use `ppa:xtradeb/apps` for jammy & noble
pat-s Sep 17, 2024
b5ed32b
schema
pat-s Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 51 additions & 41 deletions rules/chrome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,82 @@
{
"patterns": [
"\\bchrome\\b"
"\\bchrome\\b",
"\\bchromium\\b"
],
"dependencies": [
{
"pre_install": [],
"packages": ["chromium-browser"],
"post_install": [],
"constraints": [
{
"os": "linux",
"distribution": "ubuntu",
"versions": ["20.04", "22.04"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Ubuntu 24.04 supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good catch, I lost it in the refactoring as starting with 24.04, the key is chromium instead of chromium-browser. Added it.

}
]
},
{
"pre_install": [
{ "command": "[ $(which google-chrome) ] || apt-get install -y gnupg curl" },
{ "command": "[ $(which google-chrome) ] || curl -fsSL -o /tmp/google-chrome.deb https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb" },
{ "command": "[ $(which google-chrome) ] || DEBIAN_FRONTEND='noninteractive' apt-get install -y /tmp/google-chrome.deb" }
],
"packages": [],
"post_install": [
{ "command": "rm -f /tmp/google-chrome.deb" }
{ "command": "dnf install -y dnf-plugins-core" },
{ "command": "dnf config-manager --set-enabled crb" },
{ "command": "dnf install -y epel-release" }
],
"packages": ["chromium"],
"post_install": [],
"constraints": [
{
"os": "linux",
"distribution": "ubuntu"
},
"distribution": "rockylinux"
}
]
},
{
"pre_install": [
{ "command": "subscription-manager repos --enable codeready-builder-for-rhel-8-$(arch)-rpms" },
{ "command": "dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm" }
],
"packages": ["chromium"],
"post_install": [],
"constraints": [
{
"os": "linux",
"distribution": "debian"
"distribution": "redhat",
"versions": ["8"]
}
]
},
{
"pre_install": [
{ "command": "yum install -y which" },
{ "command": "[ $(which google-chrome) ] || curl -fsSL -o /tmp/google-chrome.rpm https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.rpm" },
{ "command": "[ $(which google-chrome) ] || yum install -y /tmp/google-chrome.rpm" }
],
"packages": [],
"post_install": [
{ "command": "rm -f /tmp/google-chrome.rpm" }
{ "command": "subscription-manager repos --enable codeready-builder-for-rhel-9-$(arch)-rpms" },
{ "command": "dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm" }
],
"packages": ["chromium"],
"post_install": [],
"constraints": [
{
"os": "linux",
"distribution": "centos",
"versions": ["8"]
},
"distribution": "redhat",
"versions": ["9"]
}
]
},
{
"pre_install": [],
"packages": ["chromium"],
"post_install": [],
"constraints": [
{
"os": "linux",
"distribution": "rockylinux"
"distribution": "debian"
},
{
"os": "linux",
"distribution": "redhat",
"versions": ["8"]
"distribution": "fedora"
},
{
"os": "linux",
"distribution": "fedora",
"versions": [ "36", "37" ]
"distribution": "alpine"
}
]
},
Expand All @@ -70,21 +94,7 @@
{
"os": "linux",
"distribution": "centos",
"versions": ["7"]
},
{
"os": "linux",
"distribution": "redhat",
"versions": ["7"]
}
]
},
{
"packages": ["chromium"],
"constraints": [
{
"os": "linux",
"distribution": "alpine"
"versions": ["7", "8"]
}
]
}
Expand Down
Loading