Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postgresql-devel instead of postgresql-server-devel on redhat-8 #172

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Jul 30, 2024

At the moment, the system dependency postgresql-devel is mapped to postgresql-server-devel on redhat-8:

RPostgres    1.4.7 [bld][cmp][dl] (1.47 MB) + ✖ postgresql-server-devel

However, on rhel8 actually postgresql-devel is required to successfully install RPostgres:

** package ‘RPostgres’ successfully unpacked and MD5 sums checked
** using staged installation
Using PKG_CFLAGS=
Using PKG_LIBS=-lpq
Using PKG_PLOGR=
------------------------- ANTICONF ERROR ---------------------------
Configuration failed because libpq was not found. Try installing:
 * deb: libpq-dev libssl-dev (Debian, Ubuntu, etc)
 * rpm: postgresql-devel (Fedora, EPEL)
 * rpm: postgreql8-devel, postgresql92-devel, postgresql93-devel, or postgresql94-devel (Amazon Linux)
 * csw: postgresql_dev (Solaris)
 * brew: libpq (OSX)

Installing postgresql-devel also makes the installation work. Hence, I propose that the current mapping should be changed so that postgresql-devel is installed instead of postgresql-server-devel.

Tested in a new redhat/ubi8 container.

cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.10 (Ootpa)"

Copy link
Contributor

@glin glin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks again. These postgresql packages were actually supposed to all be switched to the client packages, but it looks like we missed CentOS/RHEL. I'd like to move over the centos8/fedora rules too, so I can add that to the PR real quick..

@glin
Copy link
Contributor

glin commented Jul 30, 2024

Looks like the package is now called libpq-devel since RHEL 8. I moved RHEL 9/Fedora to that too, and tested the RPostgres installation to double check.

@pat-s
Copy link
Contributor Author

pat-s commented Jul 30, 2024

Yeah, I saw libpq-devel getting installed so postgresql-devel might only be an (outdated) alias then.

Thanks for checking so quickly!

@glin glin merged commit d1a8db0 into rstudio:main Jul 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants