Make is.promising an S3 method #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That implementation couldn't detect methods defined as regular functions in the current environment or whatever. I was spooked enough to not want to try further.
jcheng5
requested review from
gadenbuie and
wch
and removed request for
gadenbuie
wch
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let frameworks besides Future work seamlessly with promise pipes and Shiny's reactives and ExtendedTask.
Question: Should
is.promising.defaultlook for anas.promisemethod for the object? That would be the easiest, but would potentially be slow (we could maybe get clever about caching results [would we have to invalidate that cache when the list of loaded namespaces changes?]).