Fix how multiple pin name matches from a Connect board are filtered (#…

…835) * Fix bug filtering multiple matches from Connect * add mocked test --------- Co-authored-by: Julia Silge <[email protected]>
rstudio · Aug 2, 2024 · 2edcccb · 2edcccb
1 parent 21e5e4e
commit 2edcccb
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/R/board_connect.R b/R/board_connect.R
@@ -458,7 +458,7 @@ rsc_content_find <- function(board, name, version = NULL, warn = TRUE) {
         class = "pins_pin_missing"
       )
     }
-    selected <- json[[name$owner %in% owner_names]]
+    selected <- json[[which(name$owner == owner_names)]]
   }
 
   content <- list(

diff --git a/tests/testthat/test-board_connect-mocks.R b/tests/testthat/test-board_connect-mocks.R
@@ -0,0 +1,25 @@
+test_that("rsc_content_find correctly filters multiple results by owner name", {
+  local_mocked_bindings(
+    rsc_GET = function(board, path, query) {
+      list(
+        list(
+          name = "penguins",
+          owner_guid = "taylor_guid",
+          guid = "bad_content_guid",
+          content_url = "wrong.url"
+        ),
+        list(
+          name = "penguins",
+          owner_guid = "toph_guid",
+          guid = "good_content_guid",
+          content_url = "correct.url"
+        )
+      )
+    },
+    rsc_user_name = function(board, guid) {
+      c(taylor_guid = "taylor", toph_guid = "toph")[[guid]]
+    }
+  )
+  found <- rsc_content_find("a board", "toph/penguins")
+  expect_identical(found, list(guid = "good_content_guid", url = "correct.url"))
+})