Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back tooltip style, textsize, and textOnly functionality #509

Merged
merged 3 commits into from
Apr 3, 2018

Conversation

schloerke
Copy link
Contributor

@schloerke schloerke commented Apr 3, 2018

Fixes: #506

Leaflet.label version Leaflet/Leaflet.label#163 was used before upgrading to rstudio v2.0.0. Leaflet.label was absorbed into L.tooltip and we did not copy over the extra argument functionalities.

library(leaflet)
leaflet() %>% addTiles() %>% setView(-118.456554, 34.09, 13) %>% addMarkers(lng = -118.456554, 
  lat = 34.105, label = "Default Label", labelOptions = labelOptions(noHide = T)) %>% 
  addMarkers(lng = -118.456554, lat = 34.095, label = "Label w/o surrounding box", 
    labelOptions = labelOptions(noHide = T, textOnly = TRUE)) %>% addMarkers(lng = -118.456554, 
  lat = 34.085, label = "label w/ textsize 15px", labelOptions = labelOptions(noHide = T, 
    textsize = "15px")) %>% addMarkers(lng = -118.456554, lat = 34.075, 
  label = "Label w/ custom CSS style", labelOptions = labelOptions(noHide = T, 
    direction = "bottom", style = list(color = "red", `font-family` = "serif", 
      `font-style` = "italic", `box-shadow` = "3px 3px rgba(0,0,0,0.25)", 
      `font-size` = "12px", `border-color` = "rgba(0,0,0,0.5)")))

PR task list:

  • Update NEWS

@schloerke schloerke merged commit a4d20da into rstudio:master Apr 3, 2018
@schloerke schloerke deleted the Leaflet.label branch April 3, 2018 20:33
schloerke added a commit that referenced this pull request Apr 3, 2018
* bump uglify version to avoid warnings

* make docs
schloerke added a commit to schloerke/leaflet that referenced this pull request Apr 3, 2018
@schloerke schloerke self-assigned this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant