Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all npm dependencies #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Jul 7, 2019

No description provided.

@jcheng5 jcheng5 requested a review from wch March 8, 2020 19:22
@jcheng5
Copy link
Member Author

jcheng5 commented Mar 8, 2020

This is failing Travis because of the code coverage command in package.json, apparently this needs to be done differently now.

Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with merging it if the problem is just the code coverage check in Travis. (I'm personally not convinced that code coverage is a particularly useful metric, anyway.)

@jcheng5
Copy link
Member Author

jcheng5 commented Mar 9, 2020

Note to future-self:

I couldn't get istanbul to work again, but c8 does. However, once I got c8 working, then mochaTest in Gruntfile.js no longer worked. This was with Mocha 7.1.0 which has experimental ES module support, but the mochaTest plugin doesn't seem to work properly with that.

@jcheng5
Copy link
Member Author

jcheng5 commented Mar 9, 2020

After CRAN release for Bootstrap and jQuery upgrade, I'll go ahead and merge this (after removing the code coverage command from ci, and upgrading all the deps again). Thanks.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants