Re-disable GPU, but only on windows #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0e7cf9.
And remove unneeded verbatims.
hadley
commented
Feb 2, 2024
| #' * [`"--disable-dev-shm-usage"`](https://peter.sh/experiments/chromium-command-line-switches/#disable-dev-shm-usage) | ||
| #' * Only added when `CI` system environment variable is set or when inside a docker instance. | ||
| #' * \verb{The /dev/shm partition is too small in certain VM environments, causing Chrome to fail or crash} | ||
| #' * The `/dev/shm` partition is too small in certain VM environments, causing Chrome to fail or crash. |
There was a problem hiding this comment.
Not sure why these entire sentences were wrapped in \verb
|
Why is this change needed? |
|
So the CI checks don't hang forever |
wch
approved these changes
Feb 5, 2024
|
Is it possible for |
|
Maaaaybe, but given that it causes it to hang on GHA, I don't have a lot of confidence that it will generally help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.