Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robot footprint model access specifiers loosened #295

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from

Conversation

rayvburn
Copy link

I propose minor changes in robot_footprint_model to allow more extension possibilities (for e.g. planners which use similar environment representation).

  • BaseRobotFootprint class
    • getInscribedRadius was a non-const method even though none of the members are changed in any of derived classes
  • TwoCirclesRobotFootprint class
    • front_offset, front_radius, rear_offset, rear_radius are marked as private which kinda blocks extension possibilities
  • LineRobotFootprint class
    • transformToWorld method was private, similarly, line_start and line_end

@amakarow
Copy link
Contributor

amakarow commented May 2, 2021

Thank you, looks good, but kinetic is outdated. Do you really need this in kinetic? We would prefer to merge into melodic/noetic.

@rayvburn
Copy link
Author

rayvburn commented May 3, 2021

Sure that Kinetic is pretty old but e.g. PAL's software for TiAGo robot seems to work best with that distro. Having that in Kinetic would be very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants