Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many changes to edge_{velocity,acceleration,jerk} #112

Open
wants to merge 15 commits into
base: melodic-devel
Choose a base branch
from

Conversation

pingplug
Copy link

@pingplug pingplug commented Dec 23, 2018

fix #89 for different types of holonomic robot

changes:

  1. use normalized velocity/acceleration/jerk (remove max_vel_x_backwards support)
  2. add option omni_type for different holonomic types
  3. move computeError() from include/teb_local_planner/g2o_types/ to src/g2o_types
  4. add exact_arc_length support to holonomic robots
  5. add jerk edges for jerk control, add {weight_,}_jerk_lim_{x,y,theta} options
  6. tweak default {weight_,}_{acc,jerk}_lim_{x,y,theta} value

This PR was (partly) used in Jingdong Robotics Challenge 2018

@pingplug
Copy link
Author

I'm adding too much stuff on these hpp files, and most part of them are the same

when get acceleration, we have to calculate velocity twice (and another three times if we want jerk optimization)

there is something not right

@pingplug
Copy link
Author

so far this code is work, but not good...

@pingplug
Copy link
Author

another question: should we use normalized velocity/acceleration?

@pingplug
Copy link
Author

yet another question: why use non holonomic constraint but not abs(vy) to limit vy? I found it is actually calculating hypot(vx,vy) in EdgeVelocity. When weight_kinematics_nh is low, this is totally wrong.

@pingplug pingplug changed the title Add omni_type option (under construction) many changes to edge_{velocity,acceleration} (under construction) Dec 27, 2018
use shorter function name
add cfg_->trajectory.exact_arc_length to holonomic robot
use (fabs(dz) > delta) instead of (dz != 0)
fix acceleration bug
tweak comment
change file mode
tweak default parameters
@pingplug pingplug changed the title many changes to edge_{velocity,acceleration} (under construction) many changes to edge_{velocity,acceleration,jerk} Dec 30, 2018
Copy link

@gycyr gycyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your excellent work. I would like to know if this change can be used for non-holonomic robots.

@ingjae
Copy link

ingjae commented Jun 29, 2022

This hasn't been discussed for quite some time, but I'm curious as to why the jerk isn't being applied to Tebs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oblique trajectory instead of a straight trajectory on a holonomic robot
3 participants