Distinct last positional argument hashes from keywords on Ruby 3 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Apr 9, 2022
pirj
reviewed
Apr 9, 2022
|
|
||
| # If we don't allow the keyword splat, and the last hash contains extra keys | ||
| # then it is a positional hash. | ||
| return false if !@allows_any_kw_args && has_extra_keys |
There was a problem hiding this comment.
I guess there's a problem between 2.7 and 3.0+ with (spec/rspec/support/method_signature_verifier_spec.rb:372)
> def arity_kw(x, y = {}, z:2); end
> arity_kw(nil, {a: 1}, {z: 2})it works fine on 2.7 but fails on 3.0+:
ArgumentError: wrong number of arguments (given 3, expected 1..2)
To me, it seems that this expectation is not justified on Ruby 2.7:
expect(valid?(nil, :a => 1)).to eq(false)
as y is initialized with {:a => 1}.
I didn't look at other few failing examples yet.
pirj
force-pushed
the
improve-keyword-support-in-method-signature
branch
from
1deb3e3
to
ca9ee38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution attempt for #536
On Ruby 3 we can (with effort) distinguish between a last positional hash and a keyword hash, because the mixed behaviour we can get on other Rubies shouldn't happen.