Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: refer to JRuby as "jruby" from setup-ruby, to get latest #314

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olleolleolle
Copy link
Contributor

This PR introduces more JRuby versions to the build matrix.

@pirj
Copy link
Member

pirj commented Aug 24, 2023

I doubt we want to introduce new Ruby versions to the build.
For JRuby, there’s always the “are you using the latest?” question when there’s a bug. And we would really like to offload as our GHA gets overflown with two builds running 16+ jobs. Not to say JRuby jobs are usually the slowest to finish, so it may take 15+ minutes to a green build. Enough to steal focus and dry out the motivation to “fix a few minor things”.
Ideally, JRuby, TruffleRuby would run their builds against a stable version of RSpec, and we only keep builds for supported Ruby versions.
We’ve removed a bunch of Ruby versions in RSpec 4, but still 2.4-3.3 will all be there.

@JonRowe
Copy link
Member

JonRowe commented Aug 28, 2023

I'm a bit out of the loop on JRuby in terms of what the development cycle / actual usage is, versus strange bugs, we don't generally get a lot of JRuby specific bug reports these days giving me the tacit impression that its fairly stable. We keep some of the older versions around for legacy reasons, due to historic bugs and those will go away soon with RSpec 4 as @pirj mentions, I'm happy to keep a "current" version of JRuby in the CI suite but I'm not as interested in maintaining a spread of versions unless theres a good reason to?

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Aug 28, 2023

What I will do to this PR is keep a latest version, see how that feels.

I will not remove the legacy, ancient version's matrix elements, that's for a future change, I guess.

RSpec 4, yay for the future!

For the modern JRuby, pick "latest" by using setup-ruby's "jruby" moniker.
@olleolleolle olleolleolle changed the title CI: refer to JRuby 9.2, 9.3, 9.4 CI: refer to JRuby as "jruby" from setup-ruby, to get latest Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants