Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rake task description when creating new branch #210

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

benoittgt
Copy link
Member

Hello

I think the task need a little bit more help when you want to create a new branch. I was stuck and refers to #43 (comment) to find the right command.

@JonRowe
Copy link
Member

JonRowe commented Dec 12, 2018

I don't use these but makes sense to me!

@benoittgt
Copy link
Member Author

Thanks @JonRowe for the review. I was not using this task too... before today.

I am very curious about your way to develop on RSpec especially on multiple lib at the same time. There is a few automated tasks within the Rakefile, I see also some configuration possible within Gemfile or RSpec libs. But I don't see any clear documentation on how to or best practices. 🙂

branch = File.read(File.expand_path("../maintenance-branch", __FILE__)).chomp
%w[rspec rspec-core rspec-expectations rspec-support].each do |lib|
  library_path = File.expand_path("../../#{lib}", __FILE__)
  if File.exist?(library_path) && !ENV['USE_GIT_REPOS']
    gem lib, :path => library_path
  else
    gem lib, :git => "https://github.com/rspec/#{lib}.git", :branch => branch
  end
end

Thanks in advance

@benoittgt benoittgt merged commit 9fbc8a9 into rspec:master Dec 12, 2018
@benoittgt benoittgt deleted the custom-new-branch-rake-task branch December 12, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants