Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rsbuild-plugin-monaco-editor-nls example #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zackshen
Copy link

@zackshen zackshen commented Sep 23, 2024

I wrote a plugin, rsbuild-plugin-monaco-editor-nls, for the Monaco Editor in rsbuild to simplify localization.

@zackshen zackshen force-pushed the feat/rsbuild-plugin-monaco-editor-nls-example branch from 908a567 to 304b31e Compare September 29, 2024 14:06
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Can you resolve the conflicts?

@chenjiahan chenjiahan enabled auto-merge (squash) October 22, 2024 05:53
@zackshen
Copy link
Author

LGTM 👍 Can you resolve the conflicts?

ok,i will.

auto-merge was automatically disabled October 22, 2024 14:49

Head branch was pushed to by a user without write access

@zackshen zackshen force-pushed the feat/rsbuild-plugin-monaco-editor-nls-example branch from 304b31e to 0f98a2c Compare October 22, 2024 14:49
@chenjiahan chenjiahan enabled auto-merge (squash) October 23, 2024 02:21
@chenjiahan
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants