feat: allow to configure prettier for single dep (#8)

rspack-contrib · Jul 11, 2024 · 0d0ef4e · 0d0ef4e
1 parent c2e2131
commit 0d0ef4e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/src/helper.ts b/src/helper.ts
@@ -31,7 +31,10 @@ export const resolveConfig = async () => {
   return config.default as Config;
 };
 
-export function parseTasks(dependencies: Array<string | DependencyConfig>) {
+export function parseTasks(
+  dependencies: Array<string | DependencyConfig>,
+  globalPrettier?: boolean,
+) {
   const result: ParsedTask[] = [];
 
   for (const dep of dependencies) {
@@ -61,6 +64,7 @@ export function parseTasks(dependencies: Array<string | DependencyConfig>) {
         dtsExternals: [],
         emitFiles: [],
         packageJsonField: [],
+        prettier: globalPrettier,
         ...info,
       });
     } else {
@@ -71,6 +75,7 @@ export function parseTasks(dependencies: Array<string | DependencyConfig>) {
         externals: dep.externals ?? {},
         dtsExternals: dep.dtsExternals ?? [],
         emitFiles: dep.emitFiles ?? [],
+        prettier: dep.prettier ?? globalPrettier,
         afterBundle: dep.afterBundle,
         beforeBundle: dep.beforeBundle,
         packageJsonField: dep.packageJsonField ?? [],

diff --git a/src/index.ts b/src/index.ts
@@ -3,10 +3,10 @@ import { prebundle } from './prebundle.js';
 
 export async function run() {
   const config = await resolveConfig();
-  const parsedTasks = parseTasks(config.dependencies);
+  const parsedTasks = parseTasks(config.dependencies, config.prettier);
 
   for (const task of parsedTasks) {
-    await prebundle(task, config.externals, config.prettier);
+    await prebundle(task, config.externals);
   }
 }
 

diff --git a/src/prebundle.ts b/src/prebundle.ts
@@ -203,7 +203,6 @@ const pkgName = process.argv[2];
 export async function prebundle(
   task: ParsedTask,
   commonExternals: Record<string, string> = {},
-  prettier?: boolean,
 ) {
   if (pkgName && task.depName !== pkgName) {
     return;
@@ -230,7 +229,7 @@ export async function prebundle(
     assetBuilds: false,
   });
 
-  await emitIndex(code, task.distPath, prettier);
+  await emitIndex(code, task.distPath, task.prettier);
   emitAssets(assets, task.distPath);
   await emitDts(task, mergedExternals);
   emitLicense(task);

diff --git a/src/types.ts b/src/types.ts
@@ -12,6 +12,8 @@ export type DependencyConfig = {
   externals?: Record<string, string>;
   /** Externals types */
   dtsExternals?: Array<string | RegExp>;
+  /** Whether to prettier the code and strip comments */
+  prettier?: boolean;
   /** Emit extra entry files to map imports. */
   emitFiles?: ImportMap[];
   /** Copy extra fields from original package.json to target package.json. */
@@ -43,6 +45,7 @@ export type ParsedTask = {
   distPath: string;
   importPath: string;
   ignoreDts?: boolean;
+  prettier?: boolean;
   target: NonNullable<DependencyConfig['target']>;
   minify: NonNullable<DependencyConfig['minify']>;
   depName: NonNullable<DependencyConfig['name']>;