Skip to content

enable netty leak detector #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rsocket-transport-netty/build.gradle
Original file line number Diff line number Diff line change
@@ -39,6 +39,7 @@ dependencies {
testImplementation 'org.mockito:mockito-junit-jupiter'
testImplementation 'org.junit.jupiter:junit-jupiter-api'
testImplementation 'org.junit.jupiter:junit-jupiter-params'
testImplementation 'io.github.nettyplus:netty-leak-detector-junit-extension:0.0.6'

testRuntimeOnly 'org.bouncycastle:bcpkix-jdk15on'
testRuntimeOnly 'ch.qos.logback:logback-classic'
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@

import static org.assertj.core.api.Assertions.assertThat;

import io.github.nettyplus.leakdetector.junit.NettyLeakDetectorExtension;
import io.rsocket.Payload;
import io.rsocket.RSocket;
import io.rsocket.core.RSocketConnector;
@@ -30,12 +31,14 @@
import java.util.concurrent.ThreadLocalRandom;
import java.util.stream.Stream;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;

@ExtendWith(NettyLeakDetectorExtension.class)
public class FragmentTest {
private RSocket handler;
private CloseableChannel server;
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.rsocket.integration;

import io.github.nettyplus.leakdetector.junit.NettyLeakDetectorExtension;
import io.rsocket.Payload;
import io.rsocket.RSocket;
import io.rsocket.core.RSocketClient;
@@ -16,6 +17,7 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import reactor.core.publisher.Flux;
@@ -30,6 +32,7 @@
* Test case that reproduces the following <a
* href="https://github.com/rsocket/rsocket-java/issues/1099">GitHub Issue</a>
*/
@ExtendWith(NettyLeakDetectorExtension.class)
public class KeepaliveTest {

private static final Logger LOG = LoggerFactory.getLogger(KeepaliveTest.class);
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.rsocket.transport.netty;

import io.github.nettyplus.leakdetector.junit.NettyLeakDetectorExtension;
import io.rsocket.RSocket;
import io.rsocket.SocketAcceptor;
import io.rsocket.core.RSocketConnector;
@@ -12,11 +13,13 @@
import java.net.URI;
import java.time.Duration;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import reactor.core.publisher.Flux;
import reactor.netty.DisposableServer;
import reactor.netty.http.server.HttpServer;
import reactor.test.StepVerifier;

@ExtendWith(NettyLeakDetectorExtension.class)
public class WebSocketTransportIntegrationTest {

@Test
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@
*/
package io.rsocket.transport.netty;

import io.github.nettyplus.leakdetector.junit.NettyLeakDetectorExtension;
import io.netty.buffer.Unpooled;
import io.netty.channel.Channel;
import io.netty.channel.ChannelHandlerContext;
@@ -37,6 +38,7 @@
import java.time.Duration;
import java.util.stream.Stream;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
@@ -47,6 +49,7 @@
import reactor.netty.http.server.HttpServer;
import reactor.test.StepVerifier;

@ExtendWith(NettyLeakDetectorExtension.class)
public class WebsocketPingPongIntegrationTest {
private static final String host = "localhost";
private static final int port = 8088;