Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create updateSvpState method #2838

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Create updateSvpState method #2838

merged 2 commits into from
Nov 13, 2024
+397 −358

Commits on Nov 13, 2024

  1. Create updateSvpState method and make all svp-related-methods private 

    Minor refactors to avoid duplication code

Rewrite comment

Fix sonar complains

Handle exception when processing fund transaction. Add logs for when updating svp state

Add debug level log for when proposed fed does not exist

Not allow validation period end block to be part of validation ongoing period

Make updateSvpState private. Call it from updateCollections

Add missing import

Fix test
    @julia-zack @marcos-iov
    julia-zack authored and marcos-iov committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    272f561 View commit details
    Browse the repository at this point in the history

  2. Correct and make updateSvpState easier to follow

    @julia-zack
    julia-zack committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4083234 View commit details
    Browse the repository at this point in the history