Skip to content

Add ERC20 transfer script command #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025
Merged

Conversation

Nith567
Copy link
Contributor

@Nith567 Nith567 commented Mar 9, 2025

Enhances the functionality of the CLI tool by allowing users to transfer ERC20 tokens seamlessly on the Rootstock network

@RookieCol
Copy link

Thanks for the contribution! I believe we should integrate ERC-20 transfers into the existing transfer command rather than keeping transfer-token separate. This will improve UX, maintain consistency, and reduce code duplication.

Suggested approach:

  • Extend transfer to accept a --token flag for ERC-20 transfers.

@Nith567
Copy link
Contributor Author

Nith567 commented Mar 25, 2025

@RookieCol Successfully integrated erc20 transfers into the main transfer command for better UX and code maintainability. Now users can use a single command with the --token flag to handle both RBTC and ERC20 transfers.

Copy link
Collaborator

@ezequiel-rodriguez ezequiel-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezequiel-rodriguez ezequiel-rodriguez merged commit 8625d0c into rsksmart:main May 6, 2025
@ezequiel-rodriguez
Copy link
Collaborator

@Nith567 Thanks for your contribution! This is a really nice add-on to the transfer command 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants