Tcp signer setup with docker #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
3 times, most recently
from
852a9d1 to
38b2a64
Compare
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
from
cdf67fd to
42d2dae
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
2 times, most recently
from
dc839a9 to
50cc8a0
Compare
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
2 times, most recently
from
1c040a3 to
c271c25
Compare
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
from
4b294e6 to
623f6e2
Compare
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
from
623f6e2 to
8e640fe
Compare
jeremy-then
force-pushed
the
tcp-signer-setup-with-docker
branch
from
6052381 to
ae64872
Compare
jeremy-then
changed the title
|
marcos-iov
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
regtest-key-files-and-hsms.jsconfig file was created to include tcp signer config. For the second federation change, 2 feds configs were changed to use the tcp signer, while 1 remained as keyfile to keep testing the keyfile logic. The same was done with the third federation change.logbacksdirectory (that was inside container-action/rit-local-configswas deleted with all its.xmlfiles. Now we only have onebase-logback-config.xmlfile inconfig. From this, the logback.xmlfiles will be created dynamically from the paths inside theregtest....js` config files.A new
Dockeriflewas added to the root directory of the project, used to run the tests inside a docker container locally. Useful to simulate how it would run in the GitHub Actions job.A new
tcpsignerdirectory was added to the root directory of the project. This contains the tcp signer and manager binaries, built in Ubuntu 24 and designed to be used in Ubuntu. On MacOS, the tcpsigner need to run on Docker, that's why there is aDockerfileinside thetcpsignerdirectory, along with anrun.shscript that builds and runs the tcpsigner, and anentrypoing.shthat starts the tcpsigner and manager from inside docker.When running the tests from inside docker (running the command
npm run run-with-docer), then the tcp signers binaries will be executed directly, since this docker container runs Ubuntu 24. You can try running the tcpsigner manually by running./run.sh -h, or passing different parameters.