Skip to content

Added missing method Cursor.select_statement? #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release80
Choose a base branch
from
Open

Added missing method Cursor.select_statement? #2473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
460b72f
Added missing method Cursor.select_statement?
rammpeter Aug 25, 2025
4e9b154
Cursor.select_statement?: Exclude comments and leading newlines befor…
rammpeter Aug 25, 2025
c2573f2
Cursor.select_statement?: Exclude comments and leading newlines befor…
rammpeter Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,20 @@ def row_count
@raw_statement.getUpdateCount
end

# Is the current statement a SELECT statement?
def select_statement?
# Only simple SELECT and WITH statements are considered SELECT statements.
# because no other valid ojdbc method found to check it.

sql = @raw_statement.get_original_sql.strip

sql.gsub!(/\A\n+/, "") # remove leading newlines
sql.gsub!(/\A\r+/, "") # remove leading carriage returns
sql.gsub!(/--.*$/, "") # remove single line comments
sql.gsub!(/\/\*.*?\*\//m, "") # Remove multi-line comments (/* ... */)
sql.match?(/\A\s*(SELECT|WITH)/i)
end

def fetch(options = {})
if @raw_result_set.next
get_lob_value = options[:get_lob_value]
Expand Down