Support Rails 8.0 #2425

andynu · 2025-02-24T02:32:25Z

Building on top of #2424 this adds support for existing oracle_enhanced functionality to Rails 8.0. It may not fully support new Rails 8.0 features; For example there seems to be retry logic in rails now, and the oracle enhanced adapter is still doing its own thing.

Add write_query? implementation (mimicking postgres) to support the ability to prevent writes to a database - rails/rails@f39d72d
Replace the local implementation of execute, exec_query and its alias internal_exec_query with the new interface defined here rails/rails@fd24e5b of raw_execute, cast_result, and affected_rows. To support the affected_rows count this also had to add a row_count method to the coi and jdbc cursors.
without_prepared_statement? was removed rails/rails@2306c10

Fixes #2419

activerecord-oracle_enhanced-adapter.gemspec

andynu · 2025-03-11T18:18:20Z

Yes! Thank you.

…

On Tue, Mar 11, 2025 at 12:15 PM DanielClarke750 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In activerecord-oracle_enhanced-adapter.gemspec <#2425 (comment)> : > @@ -26,7 +26,7 @@ This adapter is superset of original ActiveRecord Oracle adapter. "rubygems_mfa_required" => "true" } - s.add_runtime_dependency("activerecord", ["~> 7.1.0"]) + s.add_runtime_dependency("activerecord", ["~> 7.2.0"]) Should this be bumped up to 8.0? — Reply to this email directly, view it on GitHub <#2425 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAONGMKCRALSMVBQT6OQF32T4DZVAVCNFSM6AAAAABXW7IN5GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZVGI3TCOJYGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

andynu · 2025-03-11T18:19:06Z

The VERSION should change too, but I'm not sure at what point in the PR process that is most appropriate.

MrTheBino · 2025-03-13T12:18:07Z

File dbms_output.rb, line 35

instrumenter .instrument(

must be

@instrumenter .instrument(

andynu · 2025-03-13T12:27:06Z

That is how it used to be.
But it appeared to have moved. Did it move back since?

From the commit:
Use the instrumenter method.

@instrumenter is not defined. It was moved to a method.

rails/rails@dc522a3

hss-mateus · 2025-03-18T13:57:16Z

rails/rails@dc522a3

This patch was only mentioned in the 8.0.2 changelog

I've tested this branch in 8.0.2 and found no issues. The only issue was the absence of the instrumenter method in 8.0.1.

chernesk · 2025-05-13T19:35:49Z

@andynu @rsim -- Is there anything that I can help with to get this issue closed at Rails 8 supported? I don't want to redo any work that's been done, but getting this completed would be super helpful for a client.

I'm glad to do any development or testing that would be helpful!

andynu · 2025-05-13T21:47:31Z

🤷 I don't have keys to this kingdom either. I'd love for this project to continue, but I'm not sure how to accomplish that beyond the PRs.

chernesk · 2025-05-14T15:14:59Z

@rsim Is there anything that I can do to assist? I'm glad to help in any way that I can.

chernesk · 2025-05-14T15:50:47Z

@rsim One more comment. The latest Rails that this gem is compatible with is 7.1 which has reached end of active support and will reach the end of security support in four months.

https://endoflife.date/rails

I'm here to help in any way that I can.

ddalcino · 2025-05-14T22:31:00Z

@andynu @rsim -- Is there anything that I can help with to get this issue closed at Rails 8 supported? I don't want to redo any work that's been done, but getting this completed would be super helpful for a client.

I'm glad to do any development or testing that would be helpful!

@yahonda As the last person to release a new version of this gem, I assume you might be the right person to ask? Is there anything we can do to help get this released?

tseuret · 2025-05-20T09:24:04Z

lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb

-              fetch_options = { get_lob_value: (name != "Writable Large Object") }
-              while row = cursor.fetch(fetch_options)
-                rows << row
+              if sql =~ /\A\s*SELECT/i # This seems a naive way to detect queries that will have row results.


This is causing an issue on my end.

I'm doing a recursive select with my_model.find_by_sql(...) (using with cte (...) as (...) SEARCH DEPTH FIRST BY ... SET ... SELECT ... )

I tried your fork on the rails-8-support branch in order to hopefully bump our Rails version but with this change I can't seamlessly upgrade :/

Is this row truly necessary ?

Edit: I tried deleting this condition and my Rails application failed while creating a view with this error ORA-24374.

There's obviously something that I'm missing about all of this and that is beyond my knowledge unfortunately 😅

Edit 2 : I tried replacing my call with a MyModel.with_recursive (available as of Rails 7.2) and this obviously fails too. It generates the following SQL statements : WITH RECURSIVE ... AS ... which doesn't seem to be compatible with Oracle SQL anyway.

@tseuret Does this fail on the current version of the gem as well or only on the Rails 8 version?

I agree that this query-regex is insufficient. Perhaps we can optimistically attempt to fetch from the cursor and handle any errors if there are no results.

Better yet, let's try to rely on the good work being done in OCI8 to determine what the type of the cursor is.

cfeac33

@chernesk It is working on 7.1.0 version of the gem. And it works again now thanks to @andynu !

I did convert our handful of queries to use CONNECT BY but kept the old ones and could verify your change. Thank you for the prompt and great work @andynu.

chernesk · 2025-06-17T23:02:27Z

@yahonda Really appreciate the 7.1.1 release.

Anything I can help with to move this issue forward?

yahonda · 2025-06-18T04:24:56Z

Would you rebase master branch?

Active record wants '?' as a bind placeholder. Without this it will not provide bind variables to exec. Oracle requires :N style bind parameters, so it a translation is required. Something went wrong in the translation between rails 7.1 and rails 7.2 so that the where("CONTAINS(table.col, ?, 0) >0", term) was no longer getting it's bind parameter translated to ':a1' like it should be. This change drops down to AREL nodes which ensures that the contains query is getting passed through the visitor pattern, specifically hitting the visit_Arel_Nodes_BindParam method to convert the param to ':a1'. I still do not understand what changed in rails, but this workaround is effective.

First test failure involves a missing method `transform_query` Seems to have been removed in this rails commit: fd24e5bfc9540fc00764a59ddf39a993bbd63ba2 rails/rails@fd24e5b This method was replaced with `preprocess_query`.

@instrumenter is not defined. It was moved to a method. rails/rails@dc522a3

- Add `write_query?` implementation (mimicking postgres) to support the ability to prevent writes to a database - rails/rails@f39d72d - Replace the local implementation of execute, exec_query and its alias internal_exec_query with the new interface defined here rails/rails@fd24e5b#diff-e6fd03cad5e3437c76b6c5db106359124dc9feab8341ade39b9ae54af001fac9 of `raw_execute`, `cast_result`, and `affected_rows`. To support the affected_rows count this also had to add a `row_count` method to the coi and jdbc cursors. - without_prepared_statement? was removed rails/rails@2306c10

drop 3.1 add 3.4

Use OCI8's cursor.type to tell us if it is a select statement. https://www.rubydoc.info/gems/ruby-oci8/OCI8/Cursor#type-instance_method

andynu · 2025-06-18T12:38:56Z

fork synced.
git rebase -ff origin/master complete.

andynu changed the title ~~Rails 8.0 support~~ Support Rails 8.0 Feb 24, 2025

DanielClarke750 reviewed Mar 11, 2025

View reviewed changes

activerecord-oracle_enhanced-adapter.gemspec Outdated Show resolved Hide resolved

tseuret reviewed May 20, 2025

View reviewed changes

ddalcino mentioned this pull request Jun 3, 2025

Add optional argument to reconnect for Rails 7.1+ compatibility #2433

Merged

Faq mentioned this pull request Jun 13, 2025

Upgrade to run with Rails 8 #2430

Closed

andynu force-pushed the rails-8-0-support branch from f5d1603 to c0b12c4 Compare June 18, 2025 12:10

andynu added 6 commits June 18, 2025 08:34

Use the new preprocess_query method

732bd4e

First test failure involves a missing method `transform_query` Seems to have been removed in this rails commit: fd24e5bfc9540fc00764a59ddf39a993bbd63ba2 rails/rails@fd24e5b This method was replaced with `preprocess_query`.

Use the instrumenter method.

82634be

@instrumenter is not defined. It was moved to a method. rails/rails@dc522a3

Change ruby requirements for rails 8.

dc89a7a

drop 3.1 add 3.4

Improve result row detection.

114a467

Use OCI8's cursor.type to tell us if it is a select statement. https://www.rubydoc.info/gems/ruby-oci8/OCI8/Cursor#type-instance_method

andynu force-pushed the rails-8-0-support branch from b8a5454 to 114a467 Compare June 18, 2025 12:36

Support Rails 8.0 #2425

Are you sure you want to change the base?

Support Rails 8.0 #2425

Uh oh!

Conversation

andynu commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

andynu commented Mar 11, 2025 via email

Uh oh!

andynu commented Mar 11, 2025

Uh oh!

MrTheBino commented Mar 13, 2025

Uh oh!

andynu commented Mar 13, 2025

Uh oh!

hss-mateus commented Mar 18, 2025

Uh oh!

chernesk commented May 13, 2025

Uh oh!

andynu commented May 13, 2025

Uh oh!

chernesk commented May 14, 2025

Uh oh!

chernesk commented May 14, 2025

Uh oh!

ddalcino commented May 14, 2025

Uh oh!

tseuret May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chernesk May 23, 2025

Choose a reason for hiding this comment

Uh oh!

andynu May 23, 2025

Choose a reason for hiding this comment

Uh oh!

andynu May 23, 2025

Choose a reason for hiding this comment

Uh oh!

tseuret May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chernesk commented Jun 17, 2025

Uh oh!

yahonda commented Jun 18, 2025

Uh oh!

andynu commented Jun 18, 2025

Uh oh!

Uh oh!

andynu commented Feb 24, 2025 •

edited

Loading

tseuret May 20, 2025 •

edited

Loading

tseuret May 26, 2025 •

edited

Loading