Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge events #1616

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: merge events #1616

wants to merge 4 commits into from

Conversation

wfk007
Copy link
Contributor

@wfk007 wfk007 commented Dec 23, 2024

feat for: #1560

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: cfb0dc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/all Patch
@rrweb/replay Patch
@rrweb/record Patch
@rrweb/types Patch
@rrweb/packer Patch
@rrweb/utils Patch
@rrweb/web-extension Patch
rrvideo Patch
@rrweb/rrweb-plugin-console-record Patch
@rrweb/rrweb-plugin-console-replay Patch
@rrweb/rrweb-plugin-sequential-id-record Patch
@rrweb/rrweb-plugin-sequential-id-replay Patch
@rrweb/rrweb-plugin-canvas-webrtc-record Patch
@rrweb/rrweb-plugin-canvas-webrtc-replay Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eoghanmurray
Copy link
Contributor

The following fixes the zygote issue in the tests:
c8b0595

@wfk007 wfk007 marked this pull request as draft February 5, 2025 02:45
@eoghanmurray
Copy link
Contributor

I think this does not solve the problem in #1560
I do have another plan to implement a 'frames per second' limit on mutations. The motivation there is where multiple mutations are operating on the same DOM element, e.g. javascript based animation. The fruit of such a plan would be the ability to merge events at record time, which might allow just a single, presumably smaller, mutation to be used for the scenario the OP wants. This approach I have in mind of directly manipulating and merging the mutation events might also be a candidate to replace rrdom (not that that isn't already doing a good job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants