Conversation
Ozodimgba
force-pushed
the
str-387
branch
9 times, most recently
from
f7f330c to
bea22e2
Compare
Ozodimgba
force-pushed
the
str-387
branch
3 times, most recently
from
b92766a to
4d9953b
Compare
…zation overhead with metrics for observability
Ozodimgba
force-pushed
the
str-387
branch
3 times, most recently
from
911c8da to
9f62d2b
Compare
lvboudre
approved these changes
Mar 5, 2026
Contributor
lvboudre
left a comment
lvboudre
left a comment
There was a problem hiding this comment.
LGTM, please acknowledge left over comment.
Comment on lines
+236
to
+238
| pub fn get_pre_encoded(&self) -> Option<&Bytes> { | ||
| self.pre_encoded.get() | ||
| } |
Contributor
There was a problem hiding this comment.
This function is not inline while the same function for transaction is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #STR-387