Conversation
|
@leafaar is it cool to add the changelog for the parallel encoding here or the changelog must accompany its corresponding commit |
There was a problem hiding this comment.
Pull request overview
This PR adds Unix domain socket (UDS) support for the gRPC listener, allowing clients to connect via unix:// addresses in addition to TCP addresses.
Changes:
- Introduced
GrpcAddressenum to support both TCP and Unix domain socket addresses - Modified gRPC server initialization to handle both TCP and UDS connection types
- Added warning when TLS is configured with Unix domain sockets
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| yellowstone-grpc-geyser/src/config.rs | Adds GrpcAddress enum with TCP/Unix variants and custom deserialization for unix:// prefix |
| yellowstone-grpc-geyser/src/grpc.rs | Updates server binding logic to create appropriate listener based on address type and handle socket cleanup |
| CHANGELOG.md | Documents the new Unix domain socket feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Ozodimgba Let's support multi-uds socket serving too please. |
5ff0c0c to
a2f02f0
Compare
|
@Ozodimgba I forgot about this, but can you add support for UDS connection inside the |
leafaar
left a comment
There was a problem hiding this comment.
good, there is some stuff to change. also the client library needs a connect_uds method on GeyserGrpcBuilder, and the examples (add examples btw) need a way to accept unix:///path/to/socket as the endpoint string.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Ozodimgba I need to the |
Cargo.toml
Outdated
| tokio = "1.47.1" | ||
| tokio-stream = "0.1.17" | ||
| tokio-util = "0.7.0" | ||
| tower = { version = "=0.4.13", features = ["util"] } |
There was a problem hiding this comment.
Do you need to pin this version?
Also, features should not be activated at the workspace but for package that actaully need it, in your case inside yellowstone-grpc-geyser/Cargo.toml.
There was a problem hiding this comment.
okay noted, let me fix that real quick
Closes #STR-314