feat: add metrics.rs, affinity_linux, end to end latency metrics#580
Open
vovkman wants to merge 24 commits intorpcpool:masterfrom
Open
feat: add metrics.rs, affinity_linux, end to end latency metrics#580vovkman wants to merge 24 commits intorpcpool:masterfrom
vovkman wants to merge 24 commits intorpcpool:masterfrom
Conversation
lvboudre
requested changes
Sep 24, 2025
Contributor
There was a problem hiding this comment.
Two things:
- This PR does not preserve existing prometheus metrics and
/debug_clientsendpoint. - This PR needs to be rebase off master branch.
I am fine with unifying metrics, though we need to make sure it migrate legacy prometheus feature as-is so current user of the plugin does not lose features.
| Opts::new("slot_status", "Lastest received slot from Geyser"), | ||
| &["status"] | ||
| ).unwrap(); | ||
| static ref SLOT_STATUS: Arc<AtomicI64> = Arc::new(AtomicI64::new(0)); |
Contributor
There was a problem hiding this comment.
Atomic64 cannot replace a IntGaugeVec (vectorized metric).
Comment on lines
-195
to
-201
| register!(SLOT_STATUS); | ||
| register!(SLOT_STATUS_PLUGIN); | ||
| register!(INVALID_FULL_BLOCKS); | ||
| register!(MESSAGE_QUEUE_SIZE); | ||
| register!(CONNECTIONS_TOTAL); | ||
| register!(SUBSCRIPTIONS_TOTAL); | ||
| register!(MISSED_STATUS_MESSAGE); |
Contributor
There was a problem hiding this comment.
This will break the Prometheus Service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
affinity-linuxso that builds work on macmetrics.rsmessage_send_latency_msmetric to tell time from message creation to transmission