This repository was archived by the owner on Dec 27, 2018. It is now read-only.
made python3 compliant #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty reasonable to me. I don't see why I can't merge it today. As far as what the next "version" is, 0.0.1rc6 probably makes most sense at this point, but I think I also ought to take a closer look changing to a less ad-hoc versioning system soon. |
|
So, I've merged the PR, and uploaded the new release to PyPi. Thanks for your PR! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve #8 for python3 compliancy.
Tested code changes under both python 2 and 3 virtual environments.
I also bumped the version to 0.0.1rc6. I'm not sure if that's correct. The version I downloaded say 0.0.1rc4, though pip itself has rc5 in place. Tell me if it should change this and I will.
Test this out, let me know of any adjustments you'd like and I can do an amended PR.