Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release of rp235x-hal 0.3.0 #901

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prepare release of rp235x-hal 0.3.0 #901

wants to merge 3 commits into from

Conversation

jannic
Copy link
Member

@jannic jannic commented Feb 15, 2025

This updates #871

winksaville and others added 2 commits February 15, 2025 23:08
@winksaville @jannic
wip: Release rp235x-hal v0.3.0
67ac78f 
Still need to add #PR and @user-name to CHANGELOG.md

I've verified that `cargo run-arm --release --bin blinky` and
`cargo run-riscv --release --bin blinky` work.
@jannic
Update rp235x-hal/CHANGELOG.md
d5690d7
9names
9names approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you intentionally left out changelog entries for #895 and #898?
If so, LGTM.

@jannic
Copy link
Member Author

jannic commented Feb 16, 2025

I assume you intentionally left out changelog entries for #895 and #898? If so, LGTM.

No, not really.
I worked on the git history, and between multiple commits for the same topic, commits that didn't affect rp235x at all etc., it was easy to miss some. And I guess at the end I got too tired and didn't sort them carefully enough. Especially the EXTEXCLALL change, fixing atomics, should definitely be mentioned.
I'll look into it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9names 9names 9names approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jannic @9names @winksaville