-
Notifications
You must be signed in to change notification settings - Fork 0
release v1.0.2 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1.0.2 #118
Conversation
インターフェースTips記事
✅ Deploy Preview for rowicy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces version 1.0.2 with a focus on code consistency, maintainability improvements, and new content. The changes modernize React component imports to use direct imports instead of namespace references, improve className composition with the cn utility, and add a new technical blog post explaining interface usage in game development.
Key Changes:
- Refactored React components (
button.tsx,badge.tsx) to use direct imports for React types andforwardRef - Updated
MemberCard.astroto use thecnutility for conditional className composition - Added new blog post
interface-tips.mdwith C# examples for interface patterns in game development
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/pages/[author]/rss.xml.js |
Changed quote style from double to single quotes for customData property |
src/content/blog/interface-tips.md |
New blog post explaining interfaces in game development with C# code examples |
src/components/ui/button.tsx |
Refactored to use direct forwardRef and ButtonHTMLAttributes imports |
src/components/ui/badge.tsx |
Refactored to use direct HTMLAttributes import instead of React.HTMLAttributes |
src/components/MemberCard.astro |
Adopted cn utility for conditional className composition |
.prettierignore |
Reorganized ignored paths with src/components/ui added to the list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@naoki-00-ito I've opened a new pull request, #119, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: naoki-00-ito <[email protected]>
Fix inconsistent indentation in interface-tips.md code block
This pull request includes several improvements and refactors across the codebase, focusing on code consistency, maintainability, and best practices. The most significant changes are grouped below:
Refactoring and Consistency Improvements
src/components/ui/button.tsxandsrc/components/ui/badge.tsxto use direct imports for React types (e.g.,ButtonHTMLAttributes,HTMLAttributes) instead of referencing them through the React namespace, and replacedReact.forwardRefwith a directforwardRefimport for consistency and clarity. [1] [2] [3] [4]src/components/MemberCard.astroto use thecnutility function for conditional class name composition, improving code readability and maintainability. [1] [2] [3] [4]Content Additions
interface-tips.md, explaining the use of interfaces in game development with C# examples, including comparisons of different approaches and best practices.Configuration and Minor Fixes
.prettierignoreto reorganize ignored paths for better clarity and maintainability.src/pages/[author]/rss.xml.jsby changing double quotes to single quotes for thecustomDataproperty. (src/pages/[author]/rss.xml.jsL31-R31)