feat(registry): add gpt-5.3-codex-spark model definition#1574
feat(registry): add gpt-5.3-codex-spark model definition#1574luispater merged 2 commits intorouter-for-me:devfrom
Conversation
Summary of ChangesHello @fbettag, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the system's capabilities by integrating a new OpenAI model, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new static model definition for gpt-5.3-codex-spark. The change is straightforward, but I've identified a couple of issues in the new model's metadata. There's a logical inconsistency where ContextLength is equal to MaxCompletionTokens, which is impractical. Additionally, the DisplayName uses a different formatting style compared to other models in the file. I've left specific comments with suggestions to address these points for better correctness and consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
excited for this |
|
hey, just tried this out and it looks like the model definition alone isn't enough - you also need to bump the codex client version headers. the backend seems to gate spark access by version, so with 0.98.0 it returns 400 "model does not exist". quick fix in const (
- codexClientVersion = "0.98.0"
- codexUserAgent = "codex_cli_rs/0.98.0 (Mac OS 26.0.1; arm64) Apple_Terminal/464"
+ codexClientVersion = "0.101.0"
+ codexUserAgent = "codex_cli_rs/0.101.0 (Mac OS 26.0.1; arm64) Apple_Terminal/464"
)works fine after that 👍 |
Summary\n- Add static OpenAI model definition for gpt-5.3-codex-spark.\n- Keep model metadata aligned to existing registry conventions and context_length semantics.\n\nRefs: #1573