Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release notes in docs #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

almarklein
Copy link

Since the release notes are now on the GH release pages.

@almarklein
Copy link
Author

Also, the latest build on RTD is from 3 years ago :) https://readthedocs.org/projects/freetype-py/builds/
Anything I can do to help with that?

@rougier
Copy link
Owner

rougier commented May 6, 2022

Yes, I need to upload the new doc. Best would be to have a github action to do that automatically. Any experience on that?

@almarklein
Copy link
Author

Normally RTD will just rerender automatically on new commits to main, but I guess the webhook is broken.

@almarklein
Copy link
Author

If you're logged into readthedocs.org, go to the project, and then the admin panel. Then it's under "integrations"
image

@rougier
Copy link
Owner

rougier commented May 15, 2022

I configured everything on readthedocs but the doc still seems outdated.

@HinTak
Copy link
Collaborator

HinTak commented Jul 28, 2024

It looks like the current ci runs twine manually, but even twine itself doesn't do that any more:

https://github.com/pypa/twine/blob/fa8e3d747959756ad20b3a26ef8a1fcb4f9cdc93/.github/workflows/release.yml#L62

@HinTak
Copy link
Collaborator

HinTak commented Jul 28, 2024

I believe this is relevant: pypa/twine#999 . FWIW, skip-python moved to trusted publisher pypi workflow in January, because the secrets.PYPI_USERNAME and secrets.PYPI_PASSWORD stopped working, I think.

@HinTak
Copy link
Collaborator

HinTak commented Aug 30, 2024

Last pass on Aug. 21, 2023
435176d
First fail on Aug. 23, 2023
83bf5d3

That's just updating between Two examples. Looks like it is a server change there.

Except the first failure, every failure after were about
Error
The required .readthedocs.yaml configuration file was not found at repository's root. Learn how to use this file in our configuration file tutorial.

@HinTak
Copy link
Collaborator

HinTak commented Aug 30, 2024

We definitely don't have a .readthedocs.yaml so that's that.

@HinTak
Copy link
Collaborator

HinTak commented Sep 2, 2024

Okay, kind of unrelated, but the docs stopped updating between Dec 17, 2018 and May 15, 2022. Then it broke in aug 2024 between 23rd and 21st.

Anyway, it works now.

While I think something needs to be done about the massively outdated release notes, I rather think importing them from the release page to the doc directory is better than deleting them - to keep the docs in one place.

@HinTak
Copy link
Collaborator

HinTak commented Sep 3, 2024

Keeping the release notes inside the repo is also perhaps more appropriate in light of the possibility that the repo may move - and github based release notes will be lost in such cases (#188).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants