Bump rotel to v0.2.4 - #95
Merged
Merged
Conversation
rotel v0.2.4 switched to the crates.io opentelemetry-proto 0.32 release, so the git pin here had to move with it: keeping rev 0948c61 (0.31) left two incompatible ResourceLogs types in the dependency graph. Align opentelemetry-semantic-conventions to 0.32.1 for the same reason. KeyValue gained a key_strindex field in proto 0.32 (a string-table reference used only by the profiling signal), so set it to 0 in otel_string_attr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the pinned
roteldependency fromv0.2.2tov0.2.4.Why the OpenTelemetry bumps came along
rotel v0.2.4 moved to the crates.io
opentelemetry-proto0.32 release. Keeping the git pin (rev = "0948c61", 0.31) left two incompatible copies of the crate in the dependency graph, soTelemetryAPI::newfailed to compile with two differentResourceLogstypes. Switching toopentelemetry-proto = "0.32.0"andopentelemetry-semantic-conventions = "0.32.1"matches what rotel resolves to.Code change
KeyValuegained akey_strindex: i32field in proto 0.32 — a string-table reference used exclusively by the profiling signal — sootel_string_attrsets it to0.Testing
cargo nextest run→ 26 tests run, 26 passed, 0 skipped.