Repository navigation
Add CI: type-check + build on every pull request - #42
Merged
tribal2 merged 1 commit intoAug 28, 2026
Merged
Conversation
The repo has no automated checks on pull requests today (only Dependabot). This adds a GitHub Actions workflow that runs the existing `pnpm run build` script (astro check && astro build) on every PR against develop and every push to develop, using the pnpm version already pinned in package.json's packageManager field. No new tooling or config decisions — just running what already exists as an npm script automatically instead of only when someone remembers to run it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's missing
The repo has no automated checks on pull requests today — `.github/` only contains `dependabot.yml`. Nothing runs a build, type-check, or lint when a PR is opened, so the only thing catching a broken contribution before merge is a maintainer noticing by hand (visible on PR #40 and #41, both showing "Checks 0").
What this adds
One new file, `.github/workflows/ci.yml`. It runs the build script that already exists in `package.json` (`astro check && astro build && node process-html.mjs`) automatically:
No new tooling, no config decisions — pnpm's version is pulled from the `packageManager` field already pinned in `package.json`, and it just runs the existing script.
Verified
Ran this for real on my fork (not just locally): opened a same-repo PR to trigger the `pull_request` event, watched the Actions run complete green in 1m37s — checkout, pnpm install, `astro check`, full `astro build` all passed. Closed that verification PR once confirmed; this PR is the real one.