Skip to content

Fix: the TUI records param must not shadow its saved termios state - #40

Merged
rossry merged 1 commit into
mainfrom
claude/luminary-tuifix-e512rh
Aug 28, 2026
Merged

rossry merged 1 commit into
mainfrom
claude/luminary-tuifix-e512rh

Conversation

@rossry

@rossry rossry commented Aug 28, 2026

Copy link
Copy Markdown
Owner

PR #39 merged just before its CI-red fix landed on the branch, so main carries one bug from the rename: run_tui's parameter had reused the TUI's own saved variable — the termios terminal attributes — so the mapping TUI would call save_state on terminal attrs and hand a MappingStore to tcsetattr. CI's mypy (luminary/mapping/ is on its list) flagged it.

One commit, cherry-picked from the #39 branch: the parameter is records. Verified against CI's exact mypy invocation (clean) and the mapping test files; full suite was green with this commit on the previous branch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N97HVk3sAr5jRGYodXcDoC


Generated by Claude Code

CI's mypy list covers luminary/mapping/ (the local gate list did not —
noted); the rename had reused the TUI's own `saved` terminal-attrs
variable. Verified against CI's exact mypy invocation: clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N97HVk3sAr5jRGYodXcDoC
@rossry
rossry merged commit 833840b into main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants