Repository navigation
Fix: the TUI records param must not shadow its saved termios state - #40
Merged
Merged
Conversation
CI's mypy list covers luminary/mapping/ (the local gate list did not — noted); the rename had reused the TUI's own `saved` terminal-attrs variable. Verified against CI's exact mypy invocation: clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N97HVk3sAr5jRGYodXcDoC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #39 merged just before its CI-red fix landed on the branch, so main carries one bug from the rename:
run_tui's parameter had reused the TUI's ownsavedvariable — the termios terminal attributes — so the mapping TUI would callsave_stateon terminal attrs and hand aMappingStoretotcsetattr. CI's mypy (luminary/mapping/is on its list) flagged it.One commit, cherry-picked from the #39 branch: the parameter is
records. Verified against CI's exact mypy invocation (clean) and the mapping test files; full suite was green with this commit on the previous branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01N97HVk3sAr5jRGYodXcDoC
Generated by Claude Code