feat: deep link push notifications to the event page (#170) - #767
feat: deep link push notifications to the event page (#170)#767saurabhhhcodes wants to merge 1 commit into
Conversation
…singh#170) Tapping an event reminder/RSVP push notification always landed the user on the home screen — the notification's event payload was only logged. - navigationRef + navigateToEvent() in App.js: taps navigate straight to EventDetail, queueing until the nav tree is ready for cold starts - Cold-start taps handled via getLastNotificationResponseAsync() - lib/notificationLinks.js: extractEventIdFromNotification (supports data.eventId and /event/{id} or scheme URLs) + waitForNavigationReady - 7 unit tests for both helpers
|
Warning Review limit reached
Next review available in: 16 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
Closes #170
Problem
Tapping an event-reminder or RSVP push notification landed users on the home screen —
response.data.url(/event/{eventId}) was merely console-logged, so the notification payload never drove navigation.Changes
app/App.js:navigationRefmounted onNavigationContainer; notification-tap handler now navigates toEventDetailwith the tapped event's id; navigation is queued (bounded poll) until the nav tree is ready, so cold-start taps work too. Cold-start launch-tap handled viaNotifications.getLastNotificationResponseAsync().app/src/lib/notificationLinks.js(new):extractEventIdFromNotification(supportsdata.eventId,/event/{id}andunievent://event/{id}forms) +waitForNavigationReady.app/src/lib/__tests__/notificationLinks.test.js: 7 tests (eventId direct, path/scheme URL parsing, no-event fallback, ready poll success/timeout).Verification
prettier --checkclean on all touched files.jest-expopreset not installed locally); tests follow the existingusePushNotifications.test.jsconventions and will run in CI.