fix(firo): parse OP_PUSHDATA1 OP_RETURN data#7
Merged
Conversation
navidR
force-pushed
the
fix/navidr/parse_pushdata1
branch
3 times, most recently
from
7e48bb2 to
3bcdbc5
Compare
RaaCT0R
requested changes
Jun 6, 2026
Contributor
Author
|
@RaaCT0R fixed all the comments. |
RaaCT0R
approved these changes
Jun 8, 2026
vorujack
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Firo Rosen data extraction for OP_RETURN outputs encoded with
OP_PUSHDATA1. Previously the Firo parser only handled direct-push OP_RETURN scripts like6a <len> <payload>, which failed for valid larger payloads encoded as6a 4c <len> <payload>. The parser now detects both formats, validates the full script length correctly, and includes test coverage for the OP_PUSHDATA1 case.