-
Notifications
You must be signed in to change notification settings - Fork 53
Add tests for Keyed types #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjcarroll
merged 9 commits into
ros2:rolling
from
fgallegosalido:feature/keyed-topics-support
Apr 7, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
79acdc2
Added support for KeyedString.
MiguelCompany 7d318df
Added support for NonKeyedWithNestedKey.
MiguelCompany 69e1e97
Added support for ComplexNestedKey.
MiguelCompany 1ce36a3
Make test_communication use idl messages instead of msg ones.
MiguelCompany 5298d3c
Skip keyed messages for RMWs other than fastrtps ones.
MiguelCompany 24b1c61
Changed copyright year on new files.
MiguelCompany c9b4cec
Added tests for KeyedLong type and test interoperability between Fast…
fgallegosalido 2a6a1bd
Update test_communication/test/subscribe_key_types.cpp
fgallegosalido cdf6b7a
Update test_communication/test/subscribe_key_types.hpp
fgallegosalido File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // Copyright 2025 Open Source Robotics Foundation, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "rclcpp/rclcpp.hpp" | ||
|
|
||
| #include "subscribe_helper.hpp" | ||
| #include "subscribe_key_types.hpp" | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_keyed_long( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::KeyedLong::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages) | ||
| { | ||
| return subscribe<test_msgs::msg::KeyedLong>( | ||
| node, message_type, expected_messages, received_messages); | ||
| } | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_keyed_string( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::KeyedString::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages) | ||
| { | ||
| return subscribe<test_msgs::msg::KeyedString>( | ||
| node, message_type, expected_messages, received_messages); | ||
| } | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_non_keyed_with_nested_key( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::NonKeyedWithNestedKey::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages) | ||
| { | ||
| return subscribe<test_msgs::msg::NonKeyedWithNestedKey>( | ||
| node, message_type, expected_messages, received_messages); | ||
| } | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_complex_nested_key( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::ComplexNestedKey::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages) | ||
| { | ||
| return subscribe<test_msgs::msg::ComplexNestedKey>( | ||
| node, message_type, expected_messages, received_messages); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright 2025 Open Source Robotics Foundation, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #ifndef SUBSCRIBE_KEY_TYPES_HPP_ | ||
| #define SUBSCRIBE_KEY_TYPES_HPP_ | ||
|
|
||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "rclcpp/rclcpp.hpp" | ||
| #include "test_msgs/msg/complex_nested_key.hpp" | ||
| #include "test_msgs/msg/keyed_long.hpp" | ||
| #include "test_msgs/msg/keyed_string.hpp" | ||
| #include "test_msgs/msg/non_keyed_with_nested_key.hpp" | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_keyed_long( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::KeyedLong::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages); | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_keyed_string( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::KeyedString::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages); | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_non_keyed_with_nested_key( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::NonKeyedWithNestedKey::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages); | ||
|
|
||
| rclcpp::SubscriptionBase::SharedPtr subscribe_complex_nested_key( | ||
| rclcpp::Node::SharedPtr node, | ||
| const std::string & message_type, | ||
| const std::vector<test_msgs::msg::ComplexNestedKey::SharedPtr> & expected_messages, | ||
| std::vector<bool> & received_messages); | ||
|
|
||
| #endif // SUBSCRIBE_KEY_TYPES_HPP_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the same change required for
srvto avoid the duplication?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this probably related to #549, although it doesn't seem to be necessary for now and can be backported later