Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to target_link_libraries. #776

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

clalancette
Copy link
Contributor

There really isn't any need to use ament_target_dependencies.

There really isn't any need to use ament_target_dependencies.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

clalancette commented Nov 22, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than a question

@clalancette clalancette merged commit 5d8191e into rolling Nov 27, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/target-link-libraries branch November 27, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants