Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop showing all of the performance plots #96

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

Stop showing all of the performance plots #96

wants to merge 1 commit into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 4, 2020 •
edited
Loading

There are now over 1000 PNG plots being generated during the nightly performance jobs. This makes the build page WAY too big and take really long to load. Even after it does, finding the plot you're interested in is almost impossible given that there are no text titles to search for (the titles are embedded in the images).

I think we should just disable the image gallery plugin. We can keep the plots as archived file artifacts so that they can be linked to from the build-over-build plots.

Results in the following diff:

Updating job 'Dci__nightly-performance_ubuntu_bionic_amd64' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -503 +503 @@
    -      <artifacts>ros2-dashing-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    +      <artifacts>ros2-dashing-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    @@ -510,10 +509,0 @@
    -    <org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder plugin="[email protected]">
    -      <imageGalleries>
    -        <org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -          <title>Performance Test Results</title>
    -          <imageWidthText />
    -          <markBuildAsUnstableIfNoArchivesFound>false</markBuildAsUnstableIfNoArchivesFound>
    -          <includes>ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</includes>
    -        </org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -      </imageGalleries>
    -    </org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder>
    >>>
Updating job 'Eci__nightly-performance_ubuntu_bionic_amd64' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -503 +503 @@
    -      <artifacts>ros2-eloquent-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    +      <artifacts>ros2-eloquent-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    @@ -510,10 +509,0 @@
    -    <org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder plugin="[email protected]">
    -      <imageGalleries>
    -        <org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -          <title>Performance Test Results</title>
    -          <imageWidthText />
    -          <markBuildAsUnstableIfNoArchivesFound>false</markBuildAsUnstableIfNoArchivesFound>
    -          <includes>ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</includes>
    -        </org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -      </imageGalleries>
    -    </org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder>
    >>>
Updating job 'Fci__nightly-performance_ubuntu_focal_amd64' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -503 +503 @@
    -      <artifacts>ros2-foxy-linux-focal-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    +      <artifacts>ros2-foxy-linux-focal-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    @@ -510,10 +509,0 @@
    -    <org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder plugin="[email protected]">
    -      <imageGalleries>
    -        <org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -          <title>Performance Test Results</title>
    -          <imageWidthText />
    -          <markBuildAsUnstableIfNoArchivesFound>false</markBuildAsUnstableIfNoArchivesFound>
    -          <includes>ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</includes>
    -        </org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -      </imageGalleries>
    -    </org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder>
    >>>

@cottsay
Stop showing all of the performance plots
164a440 
There are now over 1000 PNG plots being generated during the nightly
performance jobs. This makes the build page WAY too big and take really
long to load. Even after it does, finding the plot you're interested in
is almost impossible given that there are no text titles to search for
(the titles are embedded in the images).

I think we should just disable the image gallery plugin. We can keep the
plots as archived file artifacts so that they can be linked to from the
build-over-build plots.
@cottsay cottsay requested review from dirk-thomas and ahcorde May 4, 2020 19:33
@cottsay cottsay self-assigned this May 4, 2020
@dirk-thomas
Copy link
Member

I think we should just disable the image gallery plugin.

Would it make sense to at least show some selected plots?

@cottsay
Copy link
Member Author

cottsay commented May 4, 2020

Would it make sense to at least show some selected plots?

@ahcorde, do you have any thoughts about this? Is there some subset of of the current results you believe might be interesting to display on the build page?

The patterns appear to use "ant syntax", but that doesn't seem to buy us much here. I don't see a way to do "exclude" filtering on the matches.

@ahcorde
Copy link

ahcorde commented May 5, 2020

These plots will be always available clicking in the plots that generate the Jenkins plot plugin. All these plots ae unsorted, it's difficult to find what you are looking for or understand what is going on. +1 to remove it. Maybe you can show only "latency" but I don't have a strong opinion on that.

@dirk-thomas
Copy link
Member

@cottsay What is the status on this?

@cottsay cottsay mentioned this pull request Oct 13, 2020
Closed
@dirk-thomas dirk-thomas removed their request for review October 28, 2020 18:57
nuclearsandwich pushed a commit that referenced this pull request Dec 28, 2020
@fwalch @nuclearsandwich
Blacklist libfranka on Debian Jessie (#96)
aa81cd5 
libfranka needs at least GCC 5 to compile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cottsay @dirk-thomas @ahcorde