-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Launch preferences update: XML-first, .launch
extensions, Python launchfile declarative style
#5143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Launch preferences update: XML-first, .launch
extensions, Python launchfile declarative style
#5143
Conversation
Small note: Python launch files (paths) are only meant be to autocompleted by We could change that if we wanted to, of course. |
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
…up style, dedifferentiate languages by using .launch extension for all Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
…ions Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
e58d418
to
1004303
Compare
Converting to draft but leaving open for now. I am going to pull independent pieces out to make incremental progress on the less-dicey bits. |
Make a fairly opinionated pass on the Launch documentation and tutorials.
Main points:
literalinclude
to include large blocks especially ones that are repeated in explanations.launch
extension in all uses except references to actual existing demo files in other packages.AnyLaunchSubstitution
in all Python cases to match XML/YAML usage and move toward a less opinionated default launch usage pattern.I believe the potentially most contentious part will be the
.launch
extension, my justification is stated in Launch File Different Formats