-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update Visualizing-ROS-2-Data-With-Foxglove-Studio.rst #5053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edgimar
wants to merge
2
commits into
ros2:jazzy
Choose a base branch
from
edgimar:patch-1
base: jazzy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 3 additions & 1 deletion
4
source/How-To-Guides/Visualizing-ROS-2-Data-With-Foxglove-Studio.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the dedicated documentation how to use foxglobe studio with ROS 2.
IMO if we want to introduce
rerun
, we should have dedicated and whole procedure how to usererun
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur here. While I think it is fine to mention that Foxglove is closed source and that there are open source alternatives it is pretty unsatisfying that there is no documentation to point the end user to.
The Rerun team is pretty friendly, I'll give them a ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I heard back from Rerun. According to them, "I unfortunately wouldn't say that we're all the way there to be able to claim that Rerun has out of the box support for mcap files with ROS 2 messages yet."
Given that this is straight from the project maintainer I would be reluctant to point users in the direction of Rerun. @edgimar I appreciate the spirit of this PR, but given this information I recommend that we not merge your pull request. We would be happy to have your help on some other docs issues though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kscottz, that makes sense to me. Do you think the page should be updated so it accurately communicates the open/closed-source status of Foxglove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'm ambivalent until we have an alternative.