Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument client/service for end-to-end request/response tracking #163

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Instrument client/service for end-to-end request/response tracking #163

merged 1 commit into from
Dec 14, 2024

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Nov 17, 2024 •
edited
Loading

This adds instrumentation to clients and services using tracetools for end-to-end tracking of requests/responses. For more information, see ros2/ros2_tracing#145.

Requires ros2/ros2_tracing#145

@christophebedard christophebedard self-assigned this Nov 17, 2024
@christophebedard christophebedard mentioned this pull request Nov 17, 2024
Merged
@christophebedard christophebedard force-pushed the christophebedard/instrument-services-end-to-end branch from 4bd9f3c to 5440d55 Compare November 23, 2024 18:36
@christophebedard christophebedard marked this pull request as ready for review November 23, 2024 18:46
@christophebedard
Copy link
Member Author

Pulls: ros2/ros2_tracing#145, ros2/rmw_cyclonedds#521, ros2/rmw_fastrtps#787, #163
Gist: https://gist.githubusercontent.com/christophebedard/6de7664f9c4b0103faca7eff9ae7a757/raw/f3665ac1140f461336f4c2444f38bacfcc8f44d8/ros2.repos
BUILD args: --packages-above-and-dependencies test_tracetools tracetools tracetools_trace rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
TEST args: --packages-above test_tracetools tracetools tracetools_trace rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14947

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Dec 12, 2024
Merged
Merged
@christophebedard
Copy link
Member Author

christophebedard commented Dec 12, 2024 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard force-pushed the christophebedard/instrument-services-end-to-end branch from 5440d55 to fc3973a Compare December 13, 2024 16:06
fujitatomoya
fujitatomoya approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a one minor thing i want to confirm.

rmw_connextdds_common/src/common/rmw_impl.cpp Show resolved Hide resolved
@christophebedard christophebedard merged commit cdb8949 into rolling Dec 14, 2024
1 check passed
@christophebedard christophebedard deleted the christophebedard/instrument-services-end-to-end branch December 14, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@christophebedard christophebedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophebedard @fujitatomoya