Fix ComposableLifecycleNode autostart not using resolved name #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuperJappie08 <[email protected]>
|
There are no tests for this, as there is a lack of composable lifecycle demo/example nodes to test with at the moment. |
|
@christophebedard would you be able to review this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
fully_qualified_node_nameproperty toComposableNodeandNode, so the property meaning discrepency ofnode_namecan be avoided.(
node_nameonNodeis the fully qualified node name, whilenode_namefor aComposableNodewas the plainnode_nameas needed forcomposition_interfaces/srv/LoadNode)Fixes #479
Is this user-facing behavior change?
Did you use Generative AI?
No.
Additional Information
ComposableNodelooks like it could use a refactor, which could makelaunch_ros.actions.get_composable_node_load_requesta method of the class.Furthermore, I'm unsure of the need for the property redefinitions of
ComposableLifecycleNode(such asnode_nameetc.).Since they are inherited as well.