Add fisheye rectification #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
requested changes
Oct 16, 2019
This reverts commit 1b83555.
This reverts commit e812546.
PinholeCameraModel is misleading now that fisheye model (KB) was introduced. Hence, rename the class and file to a more general name. Class CameraModel does use the distortion model specified in the camera_info, namely pinhole, fisheye and rationa_polynomial
This was referenced Oct 27, 2019
|
@DavidTorresOcana this cant be merged until the upstream things have been merged that you pointed to. But given its just header changes, I have no issue merging once that time comes |
It would be good if you could ask to push the upstream of PRs up |
|
@DavidTorresOcana I don't have control over those repos |
|
Successfully tested in |
DavidTorresOcana
force-pushed
the
image_proc_fisheye
branch
from
fd76f52 to
2393388
Compare
|
Closing since ros-perception/vision_opencv#358 was finally merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to be able to rectify fisheye cameras calibrated with #440 #580 and #592 and aim to Fix #146
This PR depends on ros-perception/vision_opencv#306 and it is related to ros-perception/image_common#146
As this PR only intends to upgrade
image_procpackage with fisheye support, it was tested only with monocular cameras.It introduces:
Rename class PinholeCameraModel to CameraModel and headers: PinholeCameraModel is misleading. Rename the class and file to a more general name.
camera_info, including pinhole, equidistant and rational_polynomial and is able to run all methods inimage_proc, regardless of the model used