Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README.md from Wiki content #342
Create README.md from Wiki content #342
Changes from 2 commits
4dc3829
b368a5c
0d0d72a
bf62594
d4dffdd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here https://github.com/ros2/common_interfaces/blob/rolling/sensor_msgs/msg/Image.msg and https://github.com/ros2/common_interfaces/blob/rolling/sensor_msgs/msg/CameraInfo.msg
You might use this other one https://docs.ros2.org/foxy/api/sensor_msgs/msg/Image.html ? but
rolling
is not working.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.ros.org/en/rolling/p/image_transport/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to work to get the canonical link for packages to be the index page which is much better cross linked. It has a link directly to the API docs for each different version. We do need to get more README's ported. I'm doing this as a test of migrating content from the wiki . If we migrated to it's wiki page ( https://wiki.ros.org/image_transport) to it's README.md the link here would be much more useful. But as we're looking to wind down the wiki, we are considering a more bulk process and I'd like to do the linking with that in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a clue, I'm just porting the documentation as it exists trying to apply some basic heuristics.