Further cache support (cr_abstract and cr_works)#241
Open
LukasWallrich wants to merge 4 commits intoropensci:mainfrom
Open
Further cache support (cr_abstract and cr_works)#241LukasWallrich wants to merge 4 commits intoropensci:mainfrom
LukasWallrich wants to merge 4 commits intoropensci:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line with the addition to
cr_cn()in #237, I now added acache = TRUEoption tocr_worksandcr_abstract.One limitation: In
cr_works, it is based on full requests rather than individual DOIs, which is not ideal but was easier to implement and should usually be sufficient. If too many DOIs are requested at once, however, the request cannot be cached, so an informative warning is provided and the request is executed without cache.There was an issue with
vcrwhen implementing the test, and I did not understand the error - it works withoutvcrwhich seems to be what matters but I refrained from writing further tests for now, happy to continue on that if you have a suggestion for how to make vcr play nice.