Skip to content

removed unused services#305

Merged
vizsatiz merged 3 commits into
developfrom
fix/remove_unsued_services
Jul 1, 2026
Merged

removed unused services#305
vizsatiz merged 3 commits into
developfrom
fix/remove_unsued_services

Conversation

@rootflo-hardik

@rootflo-hardik rootflo-hardik commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Streamlined authentication by removing the client token generation capability and its service wiring.
  • Chores
    • Removed obsolete client-related configuration values, keeping the remaining environment, database, and JWT/provider settings intact.
  • Dependencies
    • Added llm-inference-config-module to the agents module’s dependencies.
    • Added psycopg2-binary (>=2.9.10, <3.0.0) to improve PostgreSQL runtime support.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Removes the client token service and its auth wiring, deletes related floware app config credentials, and adds new dependency declarations in the agents and flo_cloud packages.

Changes

Auth cleanup

Layer / File(s) Summary
Service and container removal
wavefront/server/modules/auth_module/auth_module/services/client_token_service.py, wavefront/server/modules/auth_module/auth_module/auth_container.py
ClientTokenService is removed, along with its import and singleton provider wiring in AuthContainer.
App config cleanup
wavefront/server/apps/floware/floware/config.ini
The client_id, client_secret, and product_id entries are removed from the [app_config] section.

Dependency updates

Layer / File(s) Summary
Agents module dependency wiring
wavefront/server/modules/agents_module/pyproject.toml
llm-inference-config-module is added to project dependencies and mapped as a uv workspace source.
Flo cloud runtime dependency
wavefront/server/packages/flo_cloud/pyproject.toml
psycopg2-binary is added as a runtime dependency with version bounds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: vizsatiz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing the unused client token service and related auth wiring.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove_unsued_services

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
wavefront/server/packages/flo_cloud/pyproject.toml (1)

23-23: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Prefer psycopg2 (source) over psycopg2-binary for production.

The dependency is correctly declared explicitly (consistent with prior guidance to avoid relying on transitive imports), and usage in flo_cloud/postgres/postgres.py confirms it's genuinely needed. However, the official psycopg2 docs state "If you are the maintainer of a published package depending on psycopg2 you shouldn't use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution." The binary wheel bundles its own libpq/libssl, which can cause version-mismatch and, under concurrency, segfault risks when interacting with the system SSL stack.

Consider switching to psycopg2 for the runtime dependency.

♻️ Proposed change
-    "psycopg2-binary>=2.9.10,<3.0.0",
+    "psycopg2>=2.9.10,<3.0.0",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@wavefront/server/packages/flo_cloud/pyproject.toml` at line 23, Update the
runtime dependency in pyproject.toml to use psycopg2 instead of psycopg2-binary
for flo_cloud, since postgres access in flo_cloud/postgres/postgres.py needs the
source package for production. Keep the version bounds aligned with the current
constraint style, and make sure the dependency remains explicit rather than
relying on transitive imports. Verify any packaging or lockfile references that
mention psycopg2-binary are updated to the source distribution name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@wavefront/server/packages/flo_cloud/pyproject.toml`:
- Line 23: Update the runtime dependency in pyproject.toml to use psycopg2
instead of psycopg2-binary for flo_cloud, since postgres access in
flo_cloud/postgres/postgres.py needs the source package for production. Keep the
version bounds aligned with the current constraint style, and make sure the
dependency remains explicit rather than relying on transitive imports. Verify
any packaging or lockfile references that mention psycopg2-binary are updated to
the source distribution name.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c700b5e-143d-4b5e-a66b-2dd4a700b84e

📥 Commits

Reviewing files that changed from the base of the PR and between 400245a and c61675e.

⛔ Files ignored due to path filters (1)
  • wavefront/server/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • wavefront/server/modules/agents_module/pyproject.toml
  • wavefront/server/packages/flo_cloud/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • wavefront/server/modules/agents_module/pyproject.toml

@vizsatiz vizsatiz merged commit fe9326d into develop Jul 1, 2026
10 checks passed
@vizsatiz vizsatiz deleted the fix/remove_unsued_services branch July 1, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants