removed unused services#305
Conversation
📝 WalkthroughWalkthroughRemoves the client token service and its auth wiring, deletes related floware app config credentials, and adds new dependency declarations in the agents and flo_cloud packages. ChangesAuth cleanup
Dependency updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
wavefront/server/packages/flo_cloud/pyproject.toml (1)
23-23: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPrefer
psycopg2(source) overpsycopg2-binaryfor production.The dependency is correctly declared explicitly (consistent with prior guidance to avoid relying on transitive imports), and usage in
flo_cloud/postgres/postgres.pyconfirms it's genuinely needed. However, the official psycopg2 docs state "If you are the maintainer of a published package depending on psycopg2 you shouldn't use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution." The binary wheel bundles its own libpq/libssl, which can cause version-mismatch and, under concurrency, segfault risks when interacting with the system SSL stack.Consider switching to
psycopg2for the runtime dependency.♻️ Proposed change
- "psycopg2-binary>=2.9.10,<3.0.0", + "psycopg2>=2.9.10,<3.0.0",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@wavefront/server/packages/flo_cloud/pyproject.toml` at line 23, Update the runtime dependency in pyproject.toml to use psycopg2 instead of psycopg2-binary for flo_cloud, since postgres access in flo_cloud/postgres/postgres.py needs the source package for production. Keep the version bounds aligned with the current constraint style, and make sure the dependency remains explicit rather than relying on transitive imports. Verify any packaging or lockfile references that mention psycopg2-binary are updated to the source distribution name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@wavefront/server/packages/flo_cloud/pyproject.toml`:
- Line 23: Update the runtime dependency in pyproject.toml to use psycopg2
instead of psycopg2-binary for flo_cloud, since postgres access in
flo_cloud/postgres/postgres.py needs the source package for production. Keep the
version bounds aligned with the current constraint style, and make sure the
dependency remains explicit rather than relying on transitive imports. Verify
any packaging or lockfile references that mention psycopg2-binary are updated to
the source distribution name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8c700b5e-143d-4b5e-a66b-2dd4a700b84e
⛔ Files ignored due to path filters (1)
wavefront/server/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
wavefront/server/modules/agents_module/pyproject.tomlwavefront/server/packages/flo_cloud/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
- wavefront/server/modules/agents_module/pyproject.toml
Summary by CodeRabbit
llm-inference-config-moduleto the agents module’s dependencies.psycopg2-binary (>=2.9.10, <3.0.0)to improve PostgreSQL runtime support.