Skip to content

Conversation

@bellenot
Copy link
Member

@bellenot bellenot commented Oct 16, 2025

Change the default install prefix from C:/Program Files/${PROJECT_NAME} to
C:/${PROJECT_NAME}-${ROOT_MAJOR_VERSION}-${ROOT_MINOR_VERSION}-${ROOT_PATCH_VERSION}
to prevent having (unsupported) spaces in the install PATH

Change the default install prefix from "C:/Program Files/${PROJECT_NAME}" to
"C:/${PROJECT_NAME}-${ROOT_MAJOR_VERSION}-${ROOT_MINOR_VERSION}-${ROOT_PATCH_VERSION}"
to prevent having (unsupported) spaces in the install PATH
@bellenot bellenot self-assigned this Oct 16, 2025
@bellenot bellenot requested review from dpiparo and hageboeck October 16, 2025 09:27
@bellenot
Copy link
Member Author

Failures are unrelated

Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Test Results

    22 files      22 suites   3d 20h 54m 24s ⏱️
 3 692 tests  3 691 ✅ 0 💤 1 ❌
79 228 runs  79 223 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 81d2f0f.

@bellenot bellenot merged commit 2986d9f into root-project:master Oct 16, 2025
21 of 27 checks passed
@bellenot bellenot deleted the change-default-install-prefix branch October 16, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants