[hist] Enable chi2 tests for TProfile #19930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files 21 suites 3d 22h 21m 37s ⏱️ For more details on these failures, see this check. Results for commit 3c61b5b. ♻️ This comment has been updated with latest results. |
wiso
reviewed
Sep 20, 2025
hageboeck
force-pushed
the
TProfileChi2Test
branch
from
987e2dc to
e1a1548
Compare
guitargeek
reviewed
Sep 23, 2025
guitargeek
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
Thank you very much! Changes that constrain the the inputs to prevent invalid computations are always welcome.
I would just prefer to return zero in the error case, to make it clear that the value can't be used. But if you prefer falling through to the TH1::Chi2Test(), I'd be also fine with it.
Good idea! I'll change it to return 0. |
hageboeck
force-pushed
the
TProfileChi2Test
branch
from
e1a1548 to
2b2cbe5
Compare
The test can only work if the uncertainties are taken into account correctly, so the Chi2Test function was overridden for all TProfile classes. Furthermore, the function will check if the profiles have the correct error option set. See also the discussion in: https://root-forum.cern.ch/t/chi2test-using-tprofile/64156/
hageboeck
force-pushed
the
TProfileChi2Test
branch
from
2b2cbe5 to
3c61b5b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reaction to this question
https://root-forum.cern.ch/t/chi2test-using-tprofile/64156
Note: I decided to ignore clang-format for the headers, because the indentation would look out of place.