[ntuple] Automatic schema evolution from enum to int #19907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
force-pushed
the
ntuple-evolution-integral
branch
from
815fc64 to
f3ab34a
Compare
Test Results 21 files 21 suites 3d 15h 56m 51s ⏱️ For more details on these failures, see this check. Results for commit 643fa1e. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Sep 17, 2025
jblomer
force-pushed
the
ntuple-evolution-integral
branch
2 times, most recently
from
e407222 to
7bcb04d
Compare
silverweed
reviewed
Sep 19, 2025
jblomer
force-pushed
the
ntuple-evolution-integral
branch
from
7bcb04d to
49440e6
Compare
That would not be strictly necessary because the column representations implictly enforce the automatic schema evolution rules for simple types. Making this explicit though allows for better error messages and it is a precondition to read enums into ints.
jblomer
force-pushed
the
ntuple-evolution-integral
branch
from
49440e6 to
643fa1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.