Skip to content

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Sep 16, 2025

Histogram statistics of unbinned values to compute the number of effective entries as well as the arithmetic mean and other statistical quantities per dimension.

@hahnjo hahnjo self-assigned this Sep 16, 2025
@hahnjo hahnjo requested a review from bellenot as a code owner September 16, 2025 13:39
@hahnjo hahnjo added in:Hist test coverage Run the test code coverage workflow on this PR labels Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

Test Results

    22 files      22 suites   3d 16h 8m 56s ⏱️
 3 684 tests  3 684 ✅ 0 💤 0 ❌
79 150 runs  79 150 ✅ 0 💤 0 ❌

Results for commit cb378c8.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 92.55319% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.81%. Comparing base (f80fd60) to head (9ba5607).
⚠️ Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
hist/histv7/inc/ROOT/RHistStats.hxx 92.55% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19899      +/-   ##
==========================================
+ Coverage   35.80%   35.81%   +0.01%     
==========================================
  Files        3387     3389       +2     
  Lines      515944   516219     +275     
  Branches   242384   242503     +119     
==========================================
+ Hits       184730   184884     +154     
- Misses     218442   218526      +84     
- Partials   112772   112809      +37     
Flag Coverage Δ
unittests 35.81% <92.55%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hahnjo hahnjo removed the test coverage Run the test code coverage workflow on this PR label Sep 16, 2025
@hahnjo
Copy link
Member Author

hahnjo commented Sep 22, 2025

Ping, this is the last PR needed before I can put together the "final" RHist = RHistEngine + RHistStats

Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I trust you on the math (it helps that the trickier parts are cross-checked).

@hahnjo hahnjo merged commit a7f2531 into root-project:master Oct 2, 2025
50 of 51 checks passed
@hahnjo hahnjo deleted the hist-stats branch October 2, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants