-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[hist] Implement RHistStats
#19899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hist] Implement RHistStats
#19899
Conversation
Test Results 22 files 22 suites 3d 16h 8m 56s ⏱️ Results for commit cb378c8. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19899 +/- ##
==========================================
+ Coverage 35.80% 35.81% +0.01%
==========================================
Files 3387 3389 +2
Lines 515944 516219 +275
Branches 242384 242503 +119
==========================================
+ Hits 184730 184884 +154
- Misses 218442 218526 +84
- Partials 112772 112809 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ping, this is the last PR needed before I can put together the "final" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I trust you on the math (it helps that the trickier parts are cross-checked).
It provides methods to compute the number of effective entries as well as the arithmetic mean, variance, and standard deviation.
Thanks Jakob for spotting the missing check.
Histogram statistics of unbinned values to compute the number of effective entries as well as the arithmetic mean and other statistical quantities per dimension.