Skip to content

Conversation

@ferdymercury
Copy link
Collaborator

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Philippe Canal <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 11, 2025

Test Results

    21 files      21 suites   3d 8h 19m 44s ⏱️
 3 257 tests  3 257 ✅ 0 💤 0 ❌
66 672 runs  66 672 ✅ 0 💤 0 ❌

Results for commit cd3298f.

♻️ This comment has been updated with latest results.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing failures are unexpected and seem to be triggered by this PR.

@ferdymercury ferdymercury requested a review from pcanal August 12, 2025 06:35
@ferdymercury
Copy link
Collaborator Author

The testing failures are unexpected and seem to be triggered by this PR.

there was one typo. Seems fixed now.

@dpiparo dpiparo self-assigned this Aug 12, 2025
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM (need squash when merging)

@pcanal pcanal merged commit a21a966 into root-project:master Aug 13, 2025
41 of 48 checks passed
@ferdymercury ferdymercury deleted the buffrename branch August 13, 2025 16:06
pcanal added a commit to pcanal/root that referenced this pull request Sep 26, 2025
pcanal added a commit that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants